02-12-2010, 03:24 PM
no offense, but your macroingscripts are really bad... use skill; wait(x) is generally really really bad... first of all there's lag involved so you can't be sure the skill will finish during the time x. second of all, you'll need to test out how long the skill takes to finish so you can know x... almost all skills give some kind of feedback when they're finished, for example hiding you either get "You have hidden yourself well." or "You fail to hide." (or something like that), instead of using "while true; useskill hiding; wait(1200); wend" a much much better way would be:
sub hiding()
....var counter = 0
....while uo.skillval("Hiding") < 1000 # Until GM'd.
........uo.deletejournal() # So that the earlier feedback don't get involved.
........counter = 0 # Reset counter.
........uo.useskill("Hiding")
........while uo.injournal("hide") == FALSE AND uo.injournal("hidden") == FALSE AND counter < 100 # Either finish or wait 5 secs (in case something went wrong).
............wait(50) # 50*100 = 5000 ms = 5 seconds.
............counter = counter + 1
........wend
....wend
end sub
# is used for commenting in inject, which means anything behind the # won't be used in the execution. it's a good practice to comment ur scripts so u remember what u've done if u come back to it later, or to help someone else understand ur script.
this was just an example script (a damn good one! ), if ur gonna use it, dont forget to remove the dots, they were but to show the structure... and if u need any help with other scripts for certain skills, pm me.
and also, i don't like the fact that u use objects for skills like itemid and arms lore... it would be much better to use types so that u can have ANY dagger (for example) and not the specific one u need to have if u use objects... especially since these skills normally arent gm'd in one day and u usually go about and do other things before u come back to macro again.
GOOD LUCK!
sub hiding()
....var counter = 0
....while uo.skillval("Hiding") < 1000 # Until GM'd.
........uo.deletejournal() # So that the earlier feedback don't get involved.
........counter = 0 # Reset counter.
........uo.useskill("Hiding")
........while uo.injournal("hide") == FALSE AND uo.injournal("hidden") == FALSE AND counter < 100 # Either finish or wait 5 secs (in case something went wrong).
............wait(50) # 50*100 = 5000 ms = 5 seconds.
............counter = counter + 1
........wend
....wend
end sub
# is used for commenting in inject, which means anything behind the # won't be used in the execution. it's a good practice to comment ur scripts so u remember what u've done if u come back to it later, or to help someone else understand ur script.
this was just an example script (a damn good one! ), if ur gonna use it, dont forget to remove the dots, they were but to show the structure... and if u need any help with other scripts for certain skills, pm me.
and also, i don't like the fact that u use objects for skills like itemid and arms lore... it would be much better to use types so that u can have ANY dagger (for example) and not the specific one u need to have if u use objects... especially since these skills normally arent gm'd in one day and u usually go about and do other things before u come back to macro again.
GOOD LUCK!
[SIGPIC][/SIGPIC]